Skip to content

Composite exception should update cause to match the correct throwable that's first in the chain#3963

Closed
premnirmal wants to merge 2 commits intoReactiveX:1.xfrom
premnirmal:composite_exception_cause_fix
Closed

Composite exception should update cause to match the correct throwable that's first in the chain#3963
premnirmal wants to merge 2 commits intoReactiveX:1.xfrom
premnirmal:composite_exception_cause_fix

Conversation

@premnirmal
Copy link

@premnirmal premnirmal commented May 25, 2016

Fixes #3679

@premnirmal premnirmal changed the title Composite exception should update cause to match the correct throwable Composite exception should update cause to match the correct throwable that's last in the chain May 25, 2016
@akarnokd
Copy link
Member

akarnokd commented May 25, 2016

Please add an unit test that shows verifies the expected behavior.

@premnirmal premnirmal changed the title Composite exception should update cause to match the correct throwable that's last in the chain Composite exception should update cause to match the correct throwable that's first in the chain May 25, 2016
@premnirmal
Copy link
Author

premnirmal commented May 25, 2016 •
edited
Loading

Updated

@zsxwing
Copy link
Member

zsxwing commented Jun 1, 2016

@premnirmal This is not correct. I just sent #3977 to fix it. Thanks anyway!

@akarnokd akarnokd added the Bug label Jun 1, 2016
@akarnokd
Copy link
Member

akarnokd commented Jun 1, 2016

Thanks for the contribution. Could you check #3977 and verify it fixes your issue?

@premnirmal
Copy link
Author

premnirmal commented Jun 1, 2016

Thanks @zsxwing , closing

@premnirmal premnirmal closed this Jun 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@premnirmal @akarnokd @zsxwing